prevent prometheus sts update loop #2987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes in kubernetes v1.17 cause an endless update loop due to validation errors cause by setting the 'apiVersion' and 'kind' fields in the StatefulSet spec. These two fields are set to empty strings by the Kube API server, and v1.17 added validation that does not allow these fields to be modified. See prometheus-operator#2950
pgier
force-pushed
the
prevent-sts-update-loop
branch
from
85d3cee
to
835dfeb
Compare
|
Very nice find. It’d say let’s do a release with this change? |
|
Doing a 0.35.1 sgtm I don’t think we really have to do a patch release for 0.34 as well. |
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in kubernetes v1.17 cause an update loop due to validation
errors cause by setting the 'apiVersion' and 'kind' fields in the
StatefulSet spec. These two fields are set to empty strings by
the Kube API server, and v1.17 added validation that does not
allow these fields to be modified.
Fixes #2950