pkg/alertmanager: define all possible receivers #3689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user-defined Alertmanager configuration declared a receiver that isn't yet supported by AlertmanagerConfig (e.g. email, Pushover or VictorOps), the receiver declaration would be dropped from the generated configuration. Closes prometheus-operator#3665 Signed-off-by: Simon Pasquier <spasquie@redhat.com>
paulfantom
reviewed
Nov 19, 2020
Comment on lines
+269
to
+279
| func (d *duration) UnmarshalText(text []byte) error { | ||
| parsed, err := time.ParseDuration(string(text)) | ||
| if err == nil { | ||
| *d = duration(parsed) | ||
| } | ||
| return err | ||
| } | ||
|
|
||
| func (d duration) MarshalText() ([]byte, error) { | ||
| return []byte(time.Duration(d).String()), nil | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user-defined Alertmanager configuration declared a receiver that
isn't yet supported by AlertmanagerConfig (e.g. email, Pushover or
VictorOps), the receiver declaration would be dropped from the generated
configuration.
Closes #3665