Add VictorOps Receiver type to AlertmanagerConfig CRD #3701
Conversation
|
Thanks! cc @grdryn |
sev3ryn
force-pushed
the
victoropts
branch
4 times, most recently
from
5df2d9f
to
1ccc228
Compare
sev3ryn
force-pushed
the
victoropts
branch
2 times, most recently
from
2b59a11
to
a237070
Compare
|
@sev3ryn seems like this needs another rebase. :) Thanks for the hard work and patience! |
|
Sounds like a good plan! |
| @@ -444,6 +446,29 @@ type EmailConfig struct { | |||
| TLSConfig *monitoringv1.SafeTLSConfig `json:"tlsConfig,omitempty"` | |||
| } | |||
|
|
|||
| // VictorOpsConfig configures notifications via VictorOps. | |||
| // See https://prometheus.io/docs/alerting/latest/configuration/#victorops_config | |||
| type VictorOpsConfig struct { | |||
There was a problem hiding this comment.
Don't we miss CustomFields here? This should be []KeyValue.
There was a problem hiding this comment.
I don't see CustomFields is alertmanager configuration
https://prometheus.io/docs/alerting/latest/configuration/#victorops_config
if it is planned in future alertmanager release I believe it should be added later. But anyways if you want it to be added I'll add
There was a problem hiding this comment.
I should have added the link to the code in the first place :)
https://github.com/prometheus/alertmanager/blob/a7f9fdadbecbb7e692d2cd8d3334e3d6de1602e1/config/notifiers.go#L483
The documentation is out-of-date unfortunately.
|
before merging this PR - please let me know - so I'll rebase all the fixup commits - to make git history nicer :) |
|
thanks for the quick update! We can squash all the commits before merging so no real need for you to autosquash things. |
|
lgtm |
fixes #3539