Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not set build user context #4019

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

paulfantom
Copy link
Member

@paulfantom paulfantom commented May 5, 2021

Fixes #3995

Release Note Template (will be copied)

Set proper build context in version package

@paulfantom paulfantom requested a review from a team as a code owner May 5, 2021 14:18
@simonpasquier
Copy link
Contributor

maybe we could pass a value indicating that it's built from the CI pipeline? Also could the Makefile not use environment variables specific to GitHub actions but rather env vars that could be set externally?

@paulfantom paulfantom force-pushed the builduser branch 3 times, most recently from 9a2dcd0 to 41c5c80 Compare June 29, 2021 11:23
@paulfantom
Copy link
Member Author

Rebased, updated to include suggestions, and fixed few smaller issues.

Signed-off-by: paulfantom <pawel@krupa.net.pl>
BUILD_BRANCH?=$(shell git branch --show-current)
BUILD_REVISION?=$(shell git rev-parse --short HEAD)
else
BUILD_USER=Action-Run-ID-$(GITHUB_RUN_ID)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@paulfantom paulfantom merged commit f0ddd0a into prometheus-operator:master Jun 29, 2021
@paulfantom paulfantom deleted the builduser branch June 29, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect build context in config-reloader image logs
2 participants