crds: Add proxy_url support for Probes #4043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulfantom
reviewed
May 25, 2021
pkg/apis/monitoring/v1/types.go
Outdated
| @@ -951,6 +951,8 @@ type ProberSpec struct { | |||
| // Path to collect metrics from. | |||
| // Defaults to `/probe`. | |||
| Path string `json:"path,omitempty"` | |||
| // Optional ProxyURL | |||
There was a problem hiding this comment.
Suggested change
| // Optional ProxyURL | |
| // Optional ProxyURL. |
There was a problem hiding this comment.
Added in 185a4f3
This passes through the proxy_url argument for probe CRDs Signed-off-by: Christian Simon <simon@swine.de>
Signed-off-by: Christian Simon <simon@swine.de>
simonswine
force-pushed
the
20210523_add-proxy_url-to-prober
branch
from
3dd2607
to
185a4f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes through the proxy_url argument for probe CRDs
Release Note Template (will be copied)