Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3256: ignore max_retries for Prometheus ver. 2.11.0+ #4103

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Issue #3256: ignore max_retries for Prometheus ver. 2.11.0+ #4103

merged 1 commit into from
Jun 15, 2021

Conversation

raptorsun
Copy link
Contributor

@raptorsun raptorsun commented Jun 14, 2021

Operator does not generate max_retries option in remote_write for Prometheus version 2.11.0 and higher. Prometheus no longer have this option since 2.11.0.

Please refer to this issue for more details.

Closes #3256

Release Note Template (will be copied)

Operator does not generate ``max_retries`` option in ``remote_write`` for Prometheus version 2.11.0 and higher.

@raptorsun raptorsun requested a review from a team as a code owner June 14, 2021 16:50
@simonpasquier
Copy link
Contributor

Thanks! lgtm

@simonpasquier simonpasquier merged commit ac489c0 into prometheus-operator:master Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove maxRetries option for remoteWrite
2 participants