thanos: allow injecting alert relabelling configuration for thanos ruler #4303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjentzsch
force-pushed
the
thanos-rule-alert-relabeling
branch
2 times, most recently
from
dc73949
to
ddad302
Compare
this extends the configuration of thanos ruler to include the advanced relabelling configuration for alerts, being identical to the alert_relabel_configs field of Prometheus
sjentzsch
force-pushed
the
thanos-rule-alert-relabeling
branch
from
ddad302
to
e230fc9
Compare
|
@simonpasquier Thanks for your comments and the fast work on this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this extends the configuration of thanos ruler to include the advanced
relabelling configuration for alerts, being identical to the
alert_relabel_configs field of Prometheus
Closes #4256
Description
With thanos-io/thanos#4125 the Prometheus Alert-Relabeling feature went in to Thanos Rule.
This configuration should also be able to set via the prometheus-operator.
Type of change
FEATURE(non-breaking change which adds functionality)Changelog entry