Allow retention to be set only by size #4590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Nice! It would be good to update the description of Retention.
Default is '24h' if RetentionSize is empty.
prometheus-operator/pkg/apis/monitoring/v1/types.go
Lines 354 to 357 in 961c333
If retention size is set and retention time is not, default retention time value will not be used. If both retention size and retention time are set, then both values will be used. Fixed prometheus-operator#2883 Signed-off-by: heylongdacoder <heylongdacoder@gmail.com>
heylongdacoder
force-pushed
the
fix/retention-size
branch
from
bb1c14e
to
324436a
Compare
philipgough
reviewed
Feb 23, 2022
|
Thanks for review :) |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If retention size is set and retention time is not, default retention
time value will not be used. If both retention size and retention time
are set, then both values will be used.
Fixed #2883
Signed-off-by: heylongdacoder heylongdacoder@gmail.com
Description
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.