New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow user to configure pod hostAliases #4787
Allow user to configure pod hostAliases #4787
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add unit tests for Prometheus and Alertmanager? thanks!
12c6ba8
to
c29146f
Compare
@simonpasquier I have added the test case for Prometheus and Alertmanager, but I need help on the e2e build error. Currently I am not familiar with the controller-gen, could you please help me on this? |
I believe that to make it work, we have to declare our own |
@simonpasquier thanks! I think I got what you meant. Let me study about the controller-gen before continuing this :) |
df59cb0
to
6ee2111
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just a few minor comments otherwise this is looking great!
Thanos Pods. Signed-off-by: heylongdacoder <heylongdacoder@gmail.com>
6ee2111
to
18b0008
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@simonpasquier thanks for the review, I learnt something :) |
Fixes #3488, Fixes #4298
Signed-off-by: heylongdacoder heylongdacoder@gmail.com
Description
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
x
in the box that apply.CHANGE
(fix or feature that would cause existing functionality to not work as expected)FEATURE
(non-breaking change which adds functionality)BUGFIX
(non-breaking change which fixes an issue)ENHANCEMENT
(non-breaking change which improves existing functionality)NONE
(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.