Change status conditions to follow conventions #4976
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently prometheus-operator status conditions don't follow kubernetes api conventions. This PR replaces the custom condition type with a definition from kubernetes/apimachinery. It also uses helper functions from apimachinery, where appropriately to reduce code duplication. This change is to be considered API breaking(!), dependent on release management and consistency guarantees. Signed-off-by: Nico Schieder <nschieder@redhat.com>
thetechnick
force-pushed
the
conventions-conform-conditions
branch
from
ce027a3
to
04d47de
Compare
|
@simonpasquier can you please take a look? |
|
Closing in favor of a follow up PR just containing observedGeneration to not break backwards compatibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently prometheus-operator status conditions don't follow kubernetes
api conventions. This PR replaces the custom condition type with a
definition from kubernetes/apimachinery.
It also uses helper functions from apimachinery, where appropriately to
reduce code duplication.
This change is to be considered API breaking(!), dependent on release
management and consistency guarantees.
Follow up from #4975
Signed-off-by: Nico Schieder nschieder@redhat.com
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.