feat: add Alertmanager's status subresource #5270
Conversation
simonpasquier
force-pushed
the
alertmanager-status
branch
6 times, most recently
from
2e1144f
to
8c430bd
Compare
| } | ||
|
|
||
| a := pobj.(*monitoringv1.Alertmanager) | ||
| a = a.DeepCopy() |
There was a problem hiding this comment.
Question, why is this necessary?
There was a problem hiding this comment.
This is to ensure that the object won't be modified underneath or that the function will not modify it further down the line. I can't find the documentation stating that it's a good practice but it's the safest approach.
| aStatus.AvailableReplicas = int32(len(stsReporter.ReadyPods())) | ||
| aStatus.UnavailableReplicas = int32(len(stsReporter.Pods) - len(stsReporter.ReadyPods())) | ||
|
|
||
| if len(stsReporter.ReadyPods()) < replicas { |
There was a problem hiding this comment.
nit: wouldn't this also work? Since we already do the calculations in the block above
| if len(stsReporter.ReadyPods()) < replicas { | |
| if aStatus.UnavailableReplicas > 0 { |
There was a problem hiding this comment.
good catch!
in fact replicas can be > 0 and number of "concrete" pods == 0 in situations where the statefulset definition doesn't generate pods (e.g. non-existing service account name).
simonpasquier
force-pushed
the
alertmanager-status
branch
from
20dca94
to
e9618b9
Compare
Following prometheus-operator#4580, this change implements the status subresource for the Alertmanager CRD. Co-authored-by: JoaoBraveCoding <jmarcal@redhat.com> Signed-off-by: Simon Pasquier <spasquie@redhat.com>
simonpasquier
force-pushed
the
alertmanager-status
branch
from
e9618b9
to
d078b93
Compare
There was a problem hiding this comment.
@simonpasquier thanks for doing this.
@JoaoBraveCoding thanks for the great job on the prior reviews as I was a bit late to the party here
Description
Following #4580, this change implements the status subresource for the Alertmanager CRD.
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.