Discord integration #5671
Merged
Discord integration #5671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
| // The secret needs to be in the same namespace as the AlertmanagerConfig | ||
| // object and accessible by the Prometheus Operator. | ||
| // +optional | ||
| APIURL *v1.SecretKeySelector `json:"apiURL,omitempty"` |
There was a problem hiding this comment.
this should be a required field? IIUC there's no global Discord URL parameter and Alertmanager will fail to load a discord config with an empty URL.
There was a problem hiding this comment.
There was a problem hiding this comment.
Strange, I can't seem to find discord configs in the docs, although I can see the support by reading Alertmanager's codebase.
There was a problem hiding this comment.
I guess the documentation on the website only shows the global config, and indeed Discord is not listed there:
There was a problem hiding this comment.
It seems like it was supposed to be released but hasn't been yet.
Co-authored-by: Simon Pasquier <spasquie@redhat.com>
Co-authored-by: Joao Marcal <joao.marcal12@gmail.com>
Co-authored-by: Joao Marcal <joao.marcal12@gmail.com>
ArthurSens
reviewed
Jun 16, 2023
Signed-off-by: Azanul <azanulhaque@gmail.com>
Azanul
force-pushed
the
discord-integration
branch
from
8ba088b
to
7a3cd44
Compare
Signed-off-by: Azanul <azanulhaque@gmail.com>
ArthurSens
reviewed
Jun 19, 2023
Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com>
docs improvement Co-authored-by: Simon Pasquier <spasquie@redhat.com>
Co-authored-by: Simon Pasquier <spasquie@redhat.com>
|
|
Apologies @Azanul maybe |
No file change, here's the log |
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
There's no such field in the Alertmanager configuration. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
And add validation on v1beta1 version. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
ArthurSens
approved these changes
Jul 5, 2023
There was a problem hiding this comment.
Thanks @Azanul for the contribution and @simonpasquier for the final push :)
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prometheus Alertmanager brings the functionality of pushing notifications to Discord using webhooks.
Fixes #5251
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry
Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.