Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: prometheus validation webhooks #5706

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feature: prometheus validation webhooks #5706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
40 changes: 34 additions & 6 deletions cmd/operator/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,12 +434,32 @@ func run() int {
}
}

validationTriggeredCounter := prometheus.NewCounter(prometheus.CounterOpts{
promRuleMutationTiggeredCounter := prometheus.NewCounter(prometheus.CounterOpts{
Name: "prometheus_operator_rule_mutation_triggered_total",
Help: "Number of times a prometheusRule object triggered mutation",
})

promRuleMutationErrorsCounter := prometheus.NewCounter(prometheus.CounterOpts{
Name: "prometheus_operator_rule_mutation_errors_total",
Help: "Number of errors that occurred while mutating a prometheusRules object",
})

promValidationTriggeredCounter := prometheus.NewCounter(prometheus.CounterOpts{
Name: "prometheus_operator_prometheus_validation_triggered_total",
Help: "Number of times a prometheus object triggered validation",
})

promValidationErrorsCounter := prometheus.NewCounter(prometheus.CounterOpts{
Name: "prometheus_operator_prometheus_validation_errors_total",
Help: "Number of errors that occurred while validating a prometheus object",
})

promRuleValidationTriggeredCounter := prometheus.NewCounter(prometheus.CounterOpts{
Name: "prometheus_operator_rule_validation_triggered_total",
Help: "DEPRECATED, removed in v0.57.0: Number of times a prometheusRule object triggered validation",
simonpasquier marked this conversation as resolved.
Show resolved Hide resolved
})

validationErrorsCounter := prometheus.NewCounter(prometheus.CounterOpts{
promRuleValidationErrorsCounter := prometheus.NewCounter(prometheus.CounterOpts{
Name: "prometheus_operator_rule_validation_errors_total",
Help: "DEPRECATED, removed in v0.57.0: Number of errors that occurred while validating a prometheusRules object",
})
Expand All @@ -457,16 +477,24 @@ func run() int {
r.MustRegister(
collectors.NewGoCollector(),
collectors.NewProcessCollector(collectors.ProcessCollectorOpts{}),
validationTriggeredCounter,
validationErrorsCounter,
promRuleMutationTiggeredCounter,
promRuleMutationErrorsCounter,
promValidationTriggeredCounter,
promValidationErrorsCounter,
promRuleValidationTriggeredCounter,
promRuleValidationErrorsCounter,
alertManagerConfigValidationTriggered,
alertManagerConfigValidationError,
version.NewCollector("prometheus_operator"),
)

admit.RegisterMetrics(
validationTriggeredCounter,
validationErrorsCounter,
promRuleMutationTiggeredCounter,
promRuleMutationErrorsCounter,
promValidationTriggeredCounter,
promValidationErrorsCounter,
promRuleValidationTriggeredCounter,
promRuleValidationErrorsCounter,
alertManagerConfigValidationTriggered,
alertManagerConfigValidationError,
)
Expand Down