Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout branch ref on Dependabot workflows #5887

Merged
merged 1 commit into from Sep 20, 2023
Merged

Conversation

ArthurSens
Copy link
Member

Description

Yet another PR trying to make #5849 pass 馃ゲ.

The latest attempt failed to push because it was on a detached HEAD reference. This PR forces the checkout to be on the PR branch

Type of change

What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Changelog entry

Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.


Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>
@ArthurSens ArthurSens requested a review from a team as a code owner September 4, 2023 17:24
@ArthurSens
Copy link
Member Author

Just clarifying the change:

Pull requests commit SHA default to the environment variable GITHUB_REF.

Here I'm changing to GITHUB_REF_NAME

Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ArthurSens ArthurSens merged commit e9a6ee6 into main Sep 20, 2023
17 checks passed
@ArthurSens ArthurSens deleted the dependabot-checkout-ref branch September 20, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants