Dynamic ThanosRuler governing service name

[verejoel]

Description

Currently it is not possible to run multiple instances of the ThanosRuler, as the service name is hardcoded. This change makes the generated service name dynamic, based on the name of the ThanosRuler resource.

Type of change

• CHANGE (fix or feature that would cause existing functionality to not work as expected)
• FEATURE (non-breaking change which adds functionality)
• BUGFIX (non-breaking change which fixes an issue)
• ENHANCEMENT (non-breaking change which improves existing functionality)
• NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Verification

Tests pass.

Changelog entry

- ThanosRuler governing service name now includes the ThanosRuler resource name.

[verejoel]

The only question I have is if the case where tr.Name is empty needs to be handled better? We could fallback to the existing governingServiceName as a default value if name is a zero string. But I see that this case is not handled for volumeName function.

[simonpasquier]

Thanks for submitting the PR! We already have #6060 (issue) and #6067 (stale PR). The latter should allow configuration of the service while keeping the current behavior (since changing it might break some users).

[simonpasquier]

The only question I have is if the case where tr.Name is empty needs to be handled better?

A ThanosRuler resource has to have a name.
https://kubernetes.io/docs/concepts/overview/working-with-objects/names/

Could you update the PR to implement the option 1 described in #6060 (comment)?