Use scoping TestUnmarshalEmptyRegexp to avoid subtle bugs when reusin…

…g variables. Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
prometheus · Jun 3, 2021 · f43e831 · f43e831
1 parent b61b520
commit f43e831
Showing 1 changed file with 14 additions and 9 deletions.
diff --git a/config/config_test.go b/config/config_test.go
@@ -679,17 +679,22 @@ func TestMarshalNilRegexp(t *testing.T) {
 
 func TestUnmarshalEmptyRegexp(t *testing.T) {
 	b := []byte(`""`)
-	var re Regexp
 
-	err := json.Unmarshal(b, &re)
-	require.NoError(t, err)
-	require.Equal(t, regexp.MustCompile("^(?:)$"), re.Regexp)
-	require.Equal(t, "", re.original)
+	{
+		var re Regexp
+		err := json.Unmarshal(b, &re)
+		require.NoError(t, err)
+		require.Equal(t, regexp.MustCompile("^(?:)$"), re.Regexp)
+		require.Equal(t, "", re.original)
+	}
 
-	err = yaml.Unmarshal(b, &re)
-	require.NoError(t, err)
-	require.Equal(t, regexp.MustCompile("^(?:)$"), re.Regexp)
-	require.Equal(t, "", re.original)
+	{
+		var re Regexp
+		err := yaml.Unmarshal(b, &re)
+		require.NoError(t, err)
+		require.Equal(t, regexp.MustCompile("^(?:)$"), re.Regexp)
+		require.Equal(t, "", re.original)
+	}
 }
 
 func TestUnmarshalNullRegexp(t *testing.T) {