Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Simple (200 OK) Health Check Endpoint #2034

Closed
kaizen1 opened this issue Sep 17, 2019 · 13 comments
Closed

Add Simple (200 OK) Health Check Endpoint #2034

kaizen1 opened this issue Sep 17, 2019 · 13 comments

Comments

@kaizen1
Copy link

kaizen1 commented Sep 17, 2019

Feature Request:

Add an http endpoint where we can do a simple 200 OK health check.
Many of us run behind a reverse proxy. We're forced to hack around with regex now for health checking. It's not working that well behind HAProxy.

For example, 10.128.0.4:9093/

Should return 200 OK to denote the server is up.

@stuartnelson3
Copy link
Contributor

What do you mean by "hack around"?

The status page would work for a simple health check.

@simonpasquier
Copy link
Member

The /-/healthy and /-/ready endpoints already exist. They both return 200 OK when the service is ready to serve HTTP requests.

@stuartnelson3
Copy link
Contributor

Ah! I remembered adding those, but didn't see them when looking through the api v1 impl. My bad :)

@kaizen1
Copy link
Author

kaizen1 commented Sep 18, 2019

In version 0.19.0 / 2019-09-03, those paths return 404 page not found.
If you want feedback in the future, ease up on closing issues until people verify the response.

@simonpasquier
Copy link
Member

In version 0.19.0 / 2019-09-03, those paths return 404 page not found.

Not for me.

@kaizen1
Copy link
Author

kaizen1 commented Sep 18, 2019

So why don't you document this fundamental feature on your GitHub page so other people can run into the same problem I'm having?

@mxinden
Copy link
Member

mxinden commented Sep 18, 2019

@kaizen1 do you want to prepare a pull reuqest to add documentation to prometheus.io/docs. prometheus/prometheus#5737 should be a good sample, but I guess this pull request would need to point at https://github.com/prometheus/docs/tree/master/content/docs/alerting directly.

@kaizen1
Copy link
Author

kaizen1 commented Sep 18, 2019

I couldn't get the suggested URLs to return 200 OK, so I can't document an unverifiable solution. That was why I asked the maintainer to document it.

@simonpasquier
Copy link
Member

@kaizen1 can you follow up on the user mailing list with the details of your setup (configuration, logs, version, ...) and the exact response from AlertManager?

@kaizen1
Copy link
Author

kaizen1 commented Sep 20, 2019

I've attached the requested information.

Note: Alertmanager is working fine. It's sending alerts via PagerDuty. I can get to the Alertmanager web ui thru my reverse proxy. I can curl from inside my network. but the /ready endpoint returns 404 page not found. See attached for other curl results. Thanks.

alertmanager.txt

@simonpasquier
Copy link
Member

It's /-/ready not /ready.

@kaizen1
Copy link
Author

kaizen1 commented Sep 23, 2019

I had already tried /-/ready same error as previously reported.
Also tried /-/ready/ same error as previously reported.
I've lost interest in this game of ping pong. This is the last feedback I provide to you.

@simonpasquier
Copy link
Member

can you follow up on the user mailing list with the details of your setup (configuration, logs, version, ...) and the exact response from AlertManager?

The mailing list is the appropriate venue for usage questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants