Redirect /${pathPrefix} to /${pathPrefix}/ #66
Comments
juliusv
added a commit
that referenced
this issue
May 23, 2015
Previously we redirected any non-existent path to the root (or path prefix). The new behavior: Empty path prefix: - "" -> "/" - "/biz" -> 404 Path prefix "/foo/bar": - "" -> "/foo/bar/" - "/" -> "/foo/bar/" - "/foo/bar" -> "/foo/bar/" - "/biz" -> /foo/bar/biz/" (anything not starting with the path prefix gets the prefix prepended) - "/foo/bar/biz/" -> 404 This fixes #66
juliusv
added a commit
that referenced
this issue
May 23, 2015
Previously we redirected any non-existent path to the root (or path prefix). The new behavior: Empty path prefix: - "" -> "/" - "/biz" -> 404 Path prefix "/foo/bar": - "" -> "/foo/bar/" - "/" -> "/foo/bar/" - "/foo/bar" -> "/foo/bar/" - "/biz" -> /foo/bar/biz/" (anything not starting with the path prefix gets the prefix prepended) - "/foo/bar/biz/" -> 404 This fixes #66
juliusv
added a commit
that referenced
this issue
May 23, 2015
Previously we redirected any non-existent path to the root (or path prefix). The new behavior: With no path prefix: - "" -> "/" - "/biz" -> 404 With path prefix of "/foo/bar": - "" -> "/foo/bar/" - "/" -> "/foo/bar/" - "/foo/bar" -> "/foo/bar/" - "/biz" -> /foo/bar/biz" (anything not starting with the path prefix gets the prefix prepended) - "/foo/bar/biz" -> 404 This fixes #66
|
Yeah, the whole 404 behavior was broken. I did two PRs, one for alertmanager and the same for Prometheus:
Could you check if those behave correctly for you? |
hh
pushed a commit
to ii/alertmanager
that referenced
this issue
Oct 4, 2018
* strip rootfs prefix for run in docker * Use `/` as default value of path.rootfs, and parse mounts from `/proc/1/mounts`. * No need to mount `/proc` and `/sys` because we share host's PID namespace, which allows processes within the container to see all of the processes on the system. Closes: prometheus#66 Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com> Signed-off-by: Yecheng Fu <cofyc.jackson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since y'all are requiring that pathPrefix end up with / before and after it does not match
/${pathPrefix}. I usually find this somewhat annoying because sometimes I forget to type the trailing /. I think that it would be nice to redirect users to add the /.In prometheus everything that should be a 404 is redirected. I would not advocate doing this, because its somewhat strange behavior to not have a 404 page, but just doing it for the
/${pathPrefix}to/${pathPrefix}/seems relatively reasonable and is likely what the user meant to type.The text was updated successfully, but these errors were encountered: