Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tell users opening issues to use alertmanager --version #1327

Merged
merged 1 commit into from Apr 23, 2018

Conversation

tzz
Copy link
Contributor

@tzz tzz commented Apr 16, 2018

-version doesn't work as of 0.15-rc.1 so users should run alertmanager --version

@mxinden
Copy link
Member

mxinden commented Apr 16, 2018

@tzz Thanks for the fix. We have introduced DCO for the entire Prometheus Github org. That is why the DCO bot failed on your PR.

TLDR: Could you add -s to your git commit command?

@tzz
Copy link
Contributor Author

tzz commented Apr 23, 2018

@mxinden I think it adds a lot of friction to ask for -s for documentation changes, especially tiny ones like this one-liner. Can you please reconsider?

To be clear, I can use -s. I'm asking to consider that generally documentation changes are much easier from the web interface, where signing off (as far as I know) is not available.

Let me know and I'll proceed accordingly. Thank you.

@mxinden
Copy link
Member

mxinden commented Apr 23, 2018

I understand the extra work this puts on you @tzz. I am sorry about that. The DCO is there to protect us from legal issues. This is both important for actual code, as well as its documentation.

You can still use the web-interface. You only need to make sure that you add "Signed-off-by: Random J Developer random@developer.example.org" to the commit message. Does this address your concern?

Thanks to @beorn7 we now have a wiki page giving you more details: https://github.com/prometheus/prometheus/wiki/DCO-signing

@jamtur01
Copy link
Contributor

jamtur01 commented Apr 23, 2018

@tzz There's also a number of ways you can automate this for repos when you're using git on the CLI:

  • A git alias that automatically adds -s.
  • A commit message template that automatically appends the Signed-off-by line.
  • In very recent Git versions use git-interpret-trailers (see https://stackoverflow.com/a/46536244/1048941)

`-version` doesn't work as of 0.15-rc.1 so users should run `alertmanager  --version`

Signed-off-by: Ted Zlatanov <tzz@lifelogs.com>
@tzz
Copy link
Contributor Author

tzz commented Apr 23, 2018

I've updated this specific PR with the signoff header. I can live with it but it adds friction for non-technical users in particular, which I think will discourage small documentation changes.

@mxinden It's a shame Github doesn't have an easier way to add the signoff but I agree adding it manually is a decent workaround. Thank you for considering and proposing the workaround.

@jamtur01 yes, thank you for your guidance. I like all of those solutions but they are fairly technical and CLI only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants