Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nflog: use errors.New instead of fmt.Errorf for no custom error msg. #2045

Merged
merged 1 commit into from
Sep 25, 2019
Merged

nflog: use errors.New instead of fmt.Errorf for no custom error msg. #2045

merged 1 commit into from
Sep 25, 2019

Conversation

johncming
Copy link
Contributor

use errors.New instead of fmt.Errorf for no custom error msg.

simonpasquier
simonpasquier reviewed Sep 25, 2019
View reviewed changes
Copy link
Member

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update this line? Thanks!

alertmanager/nflog/nflog.go

Line 196 in dfcaf26

return fmt.Errorf("maintenance interval must not be 0")

@johncming
Copy link
Contributor Author

Could you also update this line? Thanks!

alertmanager/nflog/nflog.go

Line 196 in dfcaf26

return fmt.Errorf("maintenance interval must not be 0")

ok

@johncming
nflog: use errors.New instead of fmt.Errorf for no custom error msg.
ff87c2f 
Signed-off-by: johncming <johncming@yahoo.com>
@johncming
Copy link
Contributor Author

updated.

@simonpasquier
Copy link
Member

👍

@simonpasquier simonpasquier merged commit 3116506 into prometheus:master Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpasquier simonpasquier simonpasquier left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johncming @simonpasquier