Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: change lock from Read lock to Write Lock since function modi… #2109

Merged
merged 1 commit into from
Nov 21, 2019

Conversation

Pger-Y
Copy link
Contributor

@Pger-Y Pger-Y commented Nov 20, 2019

function setInitialFailed() modifies the struct with RLock ,it will not cause any bug becase the function is only called onece during initialization, but it's not right and really make people confused :P

…fies the struct...

Signed-off-by: John Smith <megman5576@gmail.com>
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@simonpasquier simonpasquier merged commit f76fec1 into prometheus:master Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants