Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #2498 , it would be nice to be able to read secrets from files. It's a rainy day here, so in this PR we introduce that support for all secrets in the global and individual notifier configs, based on the existing support for this in the SlackAPIKeyFile config var.
On a sort of personal node: This is useful for any alertmanager deployed in K8s as you can now use Kubernetes Secrets to manage individual config components rather than the whole config file
Comments/Criticism welcome - It's been a really interesting traipse around the codebase