Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing docs for Discord notifier #3201

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Conversation

juliusv
Copy link
Member

@juliusv juliusv commented Jan 4, 2023

Signed-off-by: Julius Volz julius.volz@gmail.com

@juliusv
Copy link
Member Author

juliusv commented Jan 4, 2023

I just added it at the end since the rest of the notifiers were already not properly alphabetically sorted anymore. As a follow-up I'll send a PR to fix that and also fix some of the secret fields that are currently indicated as strings, and some other things.

Signed-off-by: Julius Volz <julius.volz@gmail.com>
Copy link
Member

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@simonpasquier simonpasquier merged commit 9aa5974 into main Jan 4, 2023
@simonpasquier simonpasquier deleted the document-discord-notifier branch January 4, 2023 13:10
@metalmatze
Copy link
Member

Super fast! Thanks for taking care of this and sorry for not adding it in the initial PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants