Add --id flag to amtool silence query
#3241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the Web UI, we have a UI to get information on a given silence through its ID. This functionality is missing from amtool however, leading to the necessity to pull _all_ the silenced, and filter with `grep` or similar. This commit adds in a `--id` flag to the `silence query` command, which allows specifying an ID to match on, matching the functionality of the Web UI. Signed-off-by: sinkingpoint <colin@quirl.co.nz>
|
This looks great! Thank you very much for your contribution. |
|
Opps - I merged too fast, wanted to approve first. |
hoperays
pushed a commit
to hoperays/alertmanager
that referenced
this pull request
Apr 23, 2023
In the Web UI, we have a UI to get information on a given silence through its ID. This functionality is missing from amtool however, leading to the necessity to pull _all_ the silenced, and filter with `grep` or similar. This commit adds in a `--id` flag to the `silence query` command, which allows specifying an ID to match on, matching the functionality of the Web UI. Signed-off-by: sinkingpoint <colin@quirl.co.nz>
radek-ryckowski
pushed a commit
to goldmansachs/alertmanager
that referenced
this pull request
Nov 6, 2023
In the Web UI, we have a UI to get information on a given silence through its ID. This functionality is missing from amtool however, leading to the necessity to pull _all_ the silenced, and filter with `grep` or similar. This commit adds in a `--id` flag to the `silence query` command, which allows specifying an ID to match on, matching the functionality of the Web UI. Signed-off-by: sinkingpoint <colin@quirl.co.nz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Web UI, we have a UI to get information on a given silence through its ID. This functionality is missing from amtool however, leading to the necessity to pull all the silenced, and filter with
grepor similar.This commit adds in a
--idflag to thesilence querycommand, which allows specifying an ID to match on, matching the functionality of the Web UI.Signed-off-by: sinkingpoint colin@quirl.co.nz