Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for pushover devices #3318

Merged
merged 2 commits into from May 5, 2023
Merged

Add support for pushover devices #3318

merged 2 commits into from May 5, 2023

Conversation

alec-pinson
Copy link
Contributor

@alec-pinson alec-pinson commented Apr 4, 2023 •
edited

Extending Pushover integration to allow for device parameter to be used.
https://pushover.net/api#device

@alec-pinson alec-pinson mentioned this pull request Apr 5, 2023
Merged
5 tasks
@alec-pinson
Copy link
Contributor Author

Hi, @simonpasquier @w0rm @gotjosh can one of you review this when you get chance please, it's a simple addition and I've tested it, thanks 😃.

simonpasquier
simonpasquier reviewed Apr 7, 2023
View reviewed changes
Copy link
Member

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you also update the documentation in docs/configuration.md?
Am I correct in assuming that when device is empty then the notification is sent to all devices?

@alec-pinson
Add support for pushover devices
6178c58 
Signed-off-by: Alec Pinson <30310787+alec-pinson@users.noreply.github.com>
@alec-pinson
update docs
53cbb72 
Signed-off-by: Alec Pinson <30310787+alec-pinson@users.noreply.github.com>
@alec-pinson
Copy link
Contributor Author

Thanks for the PR! Could you also update the documentation in docs/configuration.md? Am I correct in assuming that when device is empty then the notification is sent to all devices?

You are correct!
Sorry it took so long to update, I was away for a week.

gotjosh
gotjosh approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@gotjosh gotjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gotjosh
Copy link
Member

gotjosh commented Apr 28, 2023

Anything else @simonpasquier ?

@gotjosh gotjosh merged commit 3b9cd04 into prometheus:main May 5, 2023
5 checks passed
@alec-pinson alec-pinson deleted the feat/support-pushover-device branch May 5, 2023 13:29
gotjosh pushed a commit that referenced this pull request Aug 7, 2023
@alec-pinson @gotjosh
Add support for pushover devices (#3318)
3d0739f 
* Add support for pushover devices

Signed-off-by: Alec Pinson <30310787+alec-pinson@users.noreply.github.com>

* update docs

Signed-off-by: Alec Pinson <30310787+alec-pinson@users.noreply.github.com>

---------

Signed-off-by: Alec Pinson <30310787+alec-pinson@users.noreply.github.com>
@gotjosh gotjosh mentioned this pull request Aug 9, 2023
Open
@simonpasquier simonpasquier mentioned this pull request Aug 29, 2023
Closed
2 tasks
radek-ryckowski pushed a commit to goldmansachs/alertmanager that referenced this pull request Nov 6, 2023
@alec-pinson @radek-ryckowski
Add support for pushover devices (prometheus#3318)
e289873 
* Add support for pushover devices

Signed-off-by: Alec Pinson <30310787+alec-pinson@users.noreply.github.com>

* update docs

Signed-off-by: Alec Pinson <30310787+alec-pinson@users.noreply.github.com>

---------

Signed-off-by: Alec Pinson <30310787+alec-pinson@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpasquier simonpasquier simonpasquier left review comments

@gotjosh gotjosh gotjosh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alec-pinson @gotjosh @simonpasquier