api/v2: Delete silence respond with 404 when silence is not found #3352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emanlodovice
force-pushed
the
silence_delete
branch
2 times, most recently
from
287a04a
to
c38432f
Compare
Signed-off-by: Emmanuel Lodovice <lodovice@amazon.com>
emanlodovice
force-pushed
the
silence_delete
branch
from
c38432f
to
2721483
Compare
|
Hi @simonpasquier good day. Can you review this PR when you get a chance? Thank you. |
2 tasks
qinxx108
pushed a commit
to qinxx108/alertmanager
that referenced
this pull request
Jul 5, 2023
…ometheus#3352) Signed-off-by: Emmanuel Lodovice <lodovice@amazon.com> Signed-off-by: Yijie Qin <qinyijie@amazon.com>
radek-ryckowski
pushed a commit
to goldmansachs/alertmanager
that referenced
this pull request
Nov 6, 2023
…ometheus#3352) Signed-off-by: Emmanuel Lodovice <lodovice@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a client attempts to delete a non-existent silence, respond with 404 instead of 500.
This PR is a rebase of an old an open PR by @hateeyan and fixes the test failures.