Support UTF-8 label matchers: Add test for PromQL braces when parsing lists of matchers #3507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
grobinson-grafana
force-pushed
the
grobinson/add-test-for-promql-matchers
branch
2 times, most recently
from
e6827e7
to
7785118
Compare
Signed-off-by: George Robinson <george.robinson@grafana.com>
|
@gotjosh could you restart |
|
I don't think this is what I meant with #3453 (comment) My understanding is that the support of This is assuming that if we're all done with the parser today we'd have no actual coverage for this scenario - if you have any other ideas or I'm just completely off please feel free to tell me so. |
Signed-off-by: George Robinson <george.robinson@grafana.com>
|
As discussed offline, we are going to replace the unit test with acceptance tests. I've just pushed that commit this morning, and so a second review would be great whenever convenient! 🙂 |
Signed-off-by: George Robinson <george.robinson@grafana.com>
| silence2 := Silence(0, 4).Match("foo").Comment("test foo") | ||
| silence1 := Silence(0, 4).Match("test1", "severity=warn").Comment("test1") | ||
| silence2 := Silence(0, 4).Match("alertname=test2", "severity=warn").Comment("test2") | ||
| silence3 := Silence(0, 4).Match("{alertname=test3}", "severity=warn").Comment("test3") |
There was a problem hiding this comment.
@gotjosh here I create a silence with the following labels:
alertname="{alertname=test3}"
severity=warn
We will be able to then see this behaviour break when we use the new fallback parser as without the additional check we talked about in #3453 (comment), it will create a silence with the following labels instead:
alertname=test3
severity=warn
qinxx108
pushed a commit
to qinxx108/alertmanager
that referenced
this pull request
Sep 13, 2023
…#3507) * Add test for PromQL braces when parsing lists of matchers Signed-off-by: George Robinson <george.robinson@grafana.com> * Use acceptance tests Signed-off-by: George Robinson <george.robinson@grafana.com> * Add test creating silence with braces Signed-off-by: George Robinson <george.robinson@grafana.com> --------- Signed-off-by: George Robinson <george.robinson@grafana.com> Signed-off-by: Yijie Qin <qinyijie@amazon.com>
grobinson-grafana
changed the title
qinxx108
pushed a commit
to qinxx108/alertmanager
that referenced
this pull request
Sep 14, 2023
…#3507) * Add test for PromQL braces when parsing lists of matchers Signed-off-by: George Robinson <george.robinson@grafana.com> * Use acceptance tests Signed-off-by: George Robinson <george.robinson@grafana.com> * Add test creating silence with braces Signed-off-by: George Robinson <george.robinson@grafana.com> --------- Signed-off-by: George Robinson <george.robinson@grafana.com> Signed-off-by: Yijie Qin <qinyijie@amazon.com>
alexweav
pushed a commit
to grafana/prometheus-alertmanager
that referenced
this pull request
Oct 27, 2023
…#3507) * Add test for PromQL braces when parsing lists of matchers Signed-off-by: George Robinson <george.robinson@grafana.com> * Use acceptance tests Signed-off-by: George Robinson <george.robinson@grafana.com> * Add test creating silence with braces Signed-off-by: George Robinson <george.robinson@grafana.com> --------- Signed-off-by: George Robinson <george.robinson@grafana.com>
alexweav
pushed a commit
to grafana/prometheus-alertmanager
that referenced
this pull request
Oct 27, 2023
…#3507) * Add test for PromQL braces when parsing lists of matchers Signed-off-by: George Robinson <george.robinson@grafana.com> * Use acceptance tests Signed-off-by: George Robinson <george.robinson@grafana.com> * Add test creating silence with braces Signed-off-by: George Robinson <george.robinson@grafana.com> --------- Signed-off-by: George Robinson <george.robinson@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request has been added to address the discussion #3453 (comment). Should be merged before #3483.