Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newlines in smtp password file are now ignored #3680

Merged

Conversation

giorgiga
Copy link
Contributor

This should ignore any newlines in the smtp password file (actually, the file contents are trimmed).

fixed #3549

BEWARE I did not test or even build the project after this single-line change (sorry: I don't know how to do it and honestly can't be bothered to learn how to for a drive-by contribution)

Copy link
Member

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@simonpasquier simonpasquier merged commit 7a3c189 into prometheus:main Jan 23, 2024
11 checks passed
@giorgiga giorgiga deleted the trimsmtppasswordfilecontents branch February 27, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore trailing newline in smtp_auth_password_file
2 participants