Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3513: Add GroupMarker interface #3792

Merged
merged 11 commits into from
Apr 30, 2024
Merged

#3513: Add GroupMarker interface #3792

merged 11 commits into from
Apr 30, 2024

Commits on Apr 30, 2024

  1. Add GroupMarker interface 

    This commit adds a new GroupMarker interface that marks the status
of groups. For example, whether an alert is muted because or one
or more active or mute time intervals.

It renames the existing Marker interface to AlertMarker to avoid
confusion.

Signed-off-by: George Robinson <george.robinson@grafana.com>
    @grobinson-grafana
    grobinson-grafana committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    ebf147f View commit details
    Browse the repository at this point in the history

  2. Remove newline 

    Signed-off-by: George Robinson <george.robinson@grafana.com>
    @grobinson-grafana
    grobinson-grafana committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    3c8dc62 View commit details
    Browse the repository at this point in the history

  3. Add tests 

    Signed-off-by: George Robinson <george.robinson@grafana.com>
    @grobinson-grafana
    grobinson-grafana committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    eca889b View commit details
    Browse the repository at this point in the history

  4. Change memMarker to MemMarker 

    This commit changes memMarker to MemMarker as it now implements
both the AlertMarker and GroupMarker interfaces. We can return
*memMarker, but it causes lint to fail.

Signed-off-by: George Robinson <george.robinson@grafana.com>
    @grobinson-grafana
    grobinson-grafana committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    6b056cc View commit details
    Browse the repository at this point in the history

  5. Fix marker cannot be removed 

    This commit fixes a bug in SetMuted where a marker could not be
removed. The method now works as documented in the interface.

Signed-off-by: George Robinson <george.robinson@grafana.com>
    @grobinson-grafana
    grobinson-grafana committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    64a03b8 View commit details
    Browse the repository at this point in the history

  6. Fix lint 

    Signed-off-by: George Robinson <george.robinson@grafana.com>
    @grobinson-grafana
    grobinson-grafana committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    d6055ea View commit details
    Browse the repository at this point in the history

  7. Optimize GroupMarker to remove fingerprint 

    I realized that since active and mute timings are applied to
whole group rather than individual alerts within a group,
we can remove fingerprints from the GroupMarker interface.
This will make the code much simpler and also reduce the amount
of data that needs to be tracked.

Signed-off-by: George Robinson <george.robinson@grafana.com>
    @grobinson-grafana
    grobinson-grafana committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    cbe0128 View commit details
    Browse the repository at this point in the history

  8. Fix GroupMarker interface 

    Signed-off-by: George Robinson <george.robinson@grafana.com>
    @grobinson-grafana
    grobinson-grafana committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    47e952c View commit details
    Browse the repository at this point in the history

  9. Fix comments on GroupMarker interface 

    Signed-off-by: George Robinson <george.robinson@grafana.com>
    @grobinson-grafana
    grobinson-grafana committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    3132f61 View commit details
    Browse the repository at this point in the history

  10. Fix comment in test 

    Signed-off-by: George Robinson <george.robinson@grafana.com>
    @grobinson-grafana
    grobinson-grafana committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    88dfcdb View commit details
    Browse the repository at this point in the history

  11. Add routeID to GroupMarker interface 

    Signed-off-by: George Robinson <george.robinson@grafana.com>
    @grobinson-grafana
    grobinson-grafana committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    4a2781c View commit details
    Browse the repository at this point in the history