Make route.Key() unique and remove route.ID()
#3809
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces the code in route.Key() with that of route.ID(), and removes route.ID(). The motivation behind this change is to fix a number of bugs caused by conflicting group keys such as "Different aggregation groups can share the same nflog" (prometheus#3808) and also prevent an issue where groups are incorrectly marked as muted when they are not. Signed-off-by: George Robinson <george.robinson@grafana.com>
|
I'm closing this as @gotjosh found this can have unintended side effects when a configuration is changed. For example, if a route is moved in the configuration file, but not edited, then it's index will change and cause its nflogs to be expired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces the code in
route.Key()with that ofroute.ID(), and removesroute.ID(). The motivation behind this change is to fix a number of bugs caused by conflicting group keys such as "Different aggregation groups can share the same nflog" (#3808) and also prevent an issue where groups are incorrectly marked as muted when they are not.