Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not expose resolved alerts & do not send resolved if never firing #820

Merged
merged 1 commit into from May 29, 2017

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented May 23, 2017

Do not expose resolved alerts on the /alerts endpoint. Do not send
resolved alerts to receivers if the alerts have never been fired before.

This is related to #815, but does not resolve the specified issue.

@mxinden mxinden requested review from brancz and fabxc May 23, 2017 12:59
@juliusv
Copy link
Member

juliusv commented May 26, 2017

Travis is failing with:

/app/ui/app/tests/Main.elm has an invalid module declaration. Check the first line of the file and make sure it has a valid module declaration there!
Makefile:6: recipe for target 'test' failed
make: *** [test] Error 1

@juliusv
Copy link
Member

juliusv commented May 26, 2017

I can confirm that this fixes the UI issues I observed in #815

@stuartnelson3
Copy link
Contributor

Try rebasing against master, @w0rm just updated our tests to run on CI

@w0rm
Copy link
Member

w0rm commented May 28, 2017

@stuartnelson3 the problem is because https://github.com/prometheus/alertmanager/blob/master/ui/Dockerfile doesn't fix the versions of elm-format and elm-test, it should be elm-format@0.6.1-alpha and elm-test@0.18.3.

Do not expose resolved alerts on the /alerts endpoint. Do not send
resolved alerts to receivers if the alerts have never been fired before.
@mxinden
Copy link
Member Author

mxinden commented May 29, 2017

Rebased PR. Tests are all green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants