Switch alertmanager to kingpin #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pr! I'll try to give this a look soon, and I hope some of the other folks will too :) |
|
@stuartnelson3 Apparently this PR, related to #976, also wasn't merged :) |
stuartnelson3
approved these changes
Jan 6, 2018
mitchellrj
added a commit
to skybet/prometheus-rpm
that referenced
this pull request
Jan 15, 2018
hh
pushed a commit
to ii/alertmanager
that referenced
this pull request
Oct 11, 2018
* infiniband: Add not connected i40iw0/ports/1 fixtures * infiniband: Handle issue when iWARP* RDMA modules are not available This is related to prometheus#966, and handle this error, Jun 07 13:33:24 hostname node_exporter[81888]: time="2018-06-07T13:33:24+02:00" level=error msg="ERROR: infiniband collector failed after 0.000929s: strconv.ParseUint: parsing \"N/A (no PMA)\": invalid syntax" source="collector.go:132" Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the first (easy) part of the migration to Kingpin, as discussed in #947, namely converting the alertmanager binary.
I have converted amtool as well, but since that becomes quite a bit messier, I thought we'd start here and take that in a separate PR.