Allow source_ip as a parameter #1099
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Norman Pellet <nop@open.ch>
NPellet
force-pushed
the
source_ip_as_param
branch
from
05332b9
to
c254f21
Compare
|
I guess concerns are similar as in #1098, in the sense that this could enable probing a private network via proxy (which is exactly what we want in this case), so I would suggest also a config flag to allow this. We don't mind the security issues because the BBE is targeted by a local prometheus instance and is not available from the outside. What is the fate of #1098 ? I'm not per say extremely interested in dynamic probes (though it's really cool), as most of my config is still static, and AFAIU the dynamic probing doesn't combine config file with http parameters |
NPellet
force-pushed
the
source_ip_as_param
branch
2 times, most recently
from
818cd80
to
de20d4c
Compare
added 3 commits
July 18, 2023 17:17
Signed-off-by: Norman Pellet <nop@open.ch>
Signed-off-by: Norman Pellet <nop@open.ch>
…if you're Google) Signed-off-by: Norman Pellet <nop@open.ch>
NPellet
force-pushed
the
source_ip_as_param
branch
from
374cd56
to
e1277da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our use cases, we have machines that have potentially hundreds of virtual interfaces, sitting in different networks
We'd like to set the source IP as a parameter instead of having to create ICMP and TCP probers for each interface we have.