Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prometheus/common to support --log.format option #393

Closed
wants to merge 1 commit into from

Conversation

shusugmt
Copy link

Support for json format logging in prometheus/common/promlog has been added since prometheus/common#136
This PR updates prometheus/common to the latest version which supports --log.format option.

The update also includes code change to adopt prometheus/common#129
As a result now http prober exposes new metrics described in prometheus/prometheus#3241 via /metrics endpoint.

Signed-off-by: Shu Sugimoto <shu@su.gimo.to>
@brian-brazil
Copy link
Contributor

Thanks for working on this. The newer version of common also makes all http connections use keepalives, which is undesirable for this particular exporter. That'll need work first.

@shusugmt
Copy link
Author

I just noticed there are a few similar branches trying to update prometheus/common

And found this PR #321
Then that leads to prometheus/common#133 which seems blocking this to proceed.

@shusugmt
Copy link
Author

The newer version of common also makes all http connections use keepalives, which is undesirable for this particular exporter

Solution seems quite straightforward once prometheus/common#133 got merged. Simply pass true as the third parameter to NewClientFromConfig() in https://github.com/prometheus/blackbox_exporter/pull/393/files#diff-29df7d46fe6b972c1946a34608c58ab3R219

@brian-brazil
Copy link
Contributor

This is obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants