Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop importing deprecated github.com/golang/protobuf #1175

Open
bwplotka opened this issue Dec 2, 2022 · 8 comments
Open

Stop importing deprecated github.com/golang/protobuf #1175

bwplotka opened this issue Dec 2, 2022 · 8 comments

Comments

@bwplotka
Copy link
Member

bwplotka commented Dec 2, 2022

AC:

See prometheus/common#317
@bwplotka bwplotka changed the title Stop importing deprecated github.com/golang/protobuf/proto Stop importing deprecated github.com/golang/protobuf Dec 2, 2022
@bwplotka bwplotka mentioned this issue Dec 2, 2022
Closed
@zhsj zhsj mentioned this issue Dec 22, 2022
Merged
zhsj added a commit to zhsj/client_golang that referenced this issue Dec 22, 2022
@zhsj
Replace deprecated github.com/golang/protobuf package
5e7cfb8 
This replaces usage of proto.{Float64,Int32,Int64,String,Uint32,Uint64},
which doesn't break the interface.

And remove usage of proto.MarshalTextString in wrap_test.go

Updates: prometheus#1175

Signed-off-by: Shengjing Zhu <zhsj@debian.org>
zhsj added a commit to zhsj/client_golang that referenced this issue Dec 22, 2022
@zhsj
Replace deprecated github.com/golang/protobuf package
50863b4 
This replaces usage of proto.{Float64,Int32,Int64,String,Uint32,Uint64},
which doesn't break the interface.

And remove usage of proto.MarshalTextString in wrap_test.go

Updates: prometheus#1175

Signed-off-by: Shengjing Zhu <zhsj@debian.org>
bwplotka pushed a commit that referenced this issue Dec 22, 2022
@zhsj
Replace deprecated github.com/golang/protobuf package (#1183)
7f99379 
This replaces usage of proto.{Float64,Int32,Int64,String,Uint32,Uint64},
which doesn't break the interface.

And remove usage of proto.MarshalTextString in wrap_test.go

Updates: #1175

Signed-off-by: Shengjing Zhu <zhsj@debian.org>

Signed-off-by: Shengjing Zhu <zhsj@debian.org>
@bwplotka
Copy link
Member Author

Fixed by #1183

@zhsj
Copy link
Contributor

zhsj commented Dec 22, 2022

@bwplotka since github.com/golang/protobuf is still in go.mod, thus I didn't close it by commit message. Probably keep it open until the tests have migrated as well?

@SuperQ SuperQ reopened this May 1, 2023
@SuperQ
Copy link
Member

SuperQ commented May 1, 2023

I agree, we still need to clean up the tests so the Go modules dependencies are fixed.

SuperQ added a commit that referenced this issue May 1, 2023
@SuperQ
Cleanup proto use in tests
71a1761 
Switch tests over to new proto libary, eliminating the direct dependency
on the old proto library. Note the indirect requirement is still needed
due to upstream use by the client_model package.

Related: #1175

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ SuperQ mentioned this issue May 1, 2023
Merged
SuperQ added a commit that referenced this issue May 1, 2023
@SuperQ
Cleanup proto use in tests
fa346ad 
Switch tests over to new proto libary, eliminating the direct dependency
on the old proto library. Note the indirect requirement is still needed
due to upstream use by the client_model package.

Related: #1175

Signed-off-by: SuperQ <superq@gmail.com>
SuperQ added a commit that referenced this issue May 1, 2023
@SuperQ
Cleanup proto use in tests
6a93bfe 
Switch tests over to new proto libary, eliminating the direct dependency
on the old proto library. Note the indirect requirement is still needed
due to upstream use by the client_model package.

Related: #1175

Signed-off-by: SuperQ <superq@gmail.com>
bwplotka pushed a commit that referenced this issue May 3, 2023
@SuperQ
Cleanup proto use in tests (#1264)
8a51463 
Switch tests over to new proto libary, eliminating the direct dependency
on the old proto library. Note the indirect requirement is still needed
due to upstream use by the client_model package.

Related: #1175

Signed-off-by: SuperQ <superq@gmail.com>
@drobazko
Copy link

Hey folks.
Any updates on this issue?

@rufreakde
Copy link

@SuperQ any updates?

@SuperQ
Copy link
Member

SuperQ commented Sep 7, 2023

It's up to the client_golang maintainers to cut a new release.

@ash2k
Copy link

ash2k commented Sep 8, 2023

I found prometheus/common#509 that should help remove the deprecated proto package from the transitive dependency list.

@ash2k
Copy link

ash2k commented Sep 8, 2023 •
edited
Loading

Another chain of dependencies is via the github.com/prometheus/common too:

go mod why -m github.com/golang/protobuf
# github.com/golang/protobuf
github.com/prometheus/common/config
golang.org/x/oauth2
golang.org/x/oauth2/internal
google.golang.org/appengine/urlfetch
github.com/golang/protobuf/proto

Work to address that is tracked in golang/appengine#228. After it's done, someone will need to update golang.org/x/oauth2 to use the new version (there is a google.golang.org/appengine/v2 already, so a major version bump will be needed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@ash2k @zhsj @drobazko @SuperQ @bwplotka @rufreakde