Normalize empty help values in CollectAndCompare #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to an inconsistency in the text protocol between encoding and decoding, it was not possible to use the testutil.CollectAndCompare function to test metrics with empty help values. To fix this, normalize empty help values from the expected/want side of the test so that they compare correctly with empty values on the actual/got side of the test. Signed-off-by: Billy Keyes <bluekeyes@gmail.com>
bluekeyes
force-pushed
the
testutil-empty-help
branch
from
627f5fd
to
f746a0e
Compare
ArthurSens
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
LGTM from first glance, thanks for taking care of this one!
Still, I'd like to defer the final approval and merge to @bwplotka as I'm not 100% familiar with this part of the code yet
renovate bot
added a commit
to open-feature/flagd
that referenced
this pull request
Dec 28, 2023
….0 (#1110) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/client_golang](https://togithub.com/prometheus/client_golang) | `v1.17.0` -> `v1.18.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>prometheus/client_golang (github.com/prometheus/client_golang)</summary> ### [`v1.18.0`](https://togithub.com/prometheus/client_golang/releases/tag/v1.18.0): v0.18.0 [Compare Source](https://togithub.com/prometheus/client_golang/compare/v1.17.0...v1.18.0) #### What's Changed - \[FEATURE] promlint: Allow creation of custom metric validations. [#​1311](https://togithub.com/prometheus/client_golang/issues/1311) - \[FEATURE] Go programs using client_golang can be built in wasip1 OS. [#​1350](https://togithub.com/prometheus/client_golang/issues/1350) - \[BUGFIX] histograms: Add timer to reset ASAP after bucket limiting has happened. [#​1367](https://togithub.com/prometheus/client_golang/issues/1367) - \[BUGFIX] testutil: Fix comparison of metrics with empty Help strings. [#​1378](https://togithub.com/prometheus/client_golang/issues/1378) - \[ENHANCEMENT] Improved performance of `MetricVec.WithLabelValues(...)`. [#​1360](https://togithub.com/prometheus/client_golang/issues/1360) #### New Contributors - [@​srenatus](https://togithub.com/srenatus) made their first contribution in [prometheus/client_golang#1350 - [@​jadolg](https://togithub.com/jadolg) made their first contribution in [prometheus/client_golang#1342 - [@​manas-rust](https://togithub.com/manas-rust) made their first contribution in [prometheus/client_golang#1383 - [@​bluekeyes](https://togithub.com/bluekeyes) made their first contribution in [prometheus/client_golang#1378 - [@​tsipo](https://togithub.com/tsipo) made their first contribution in [prometheus/client_golang#1387 **Full Changelog**: prometheus/client_golang@v1.17.0...v1.18.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-feature/flagd). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
charithe
pushed a commit
to cerbos/cerbos
that referenced
this pull request
Jan 2, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | Type | Update | |---|---|---|---|---|---|---|---| | [github.com/aws/aws-sdk-go](https://togithub.com/aws/aws-sdk-go) | `v1.49.10` -> `v1.49.13` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | patch | | [github.com/cerbos/cloud-api](https://togithub.com/cerbos/cloud-api) | `v0.1.12` -> `v0.1.13` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | patch | | [github.com/prometheus/client_golang](https://togithub.com/prometheus/client_golang) | `v1.17.0` -> `v1.18.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | minor | | [github.com/pterm/pterm](https://togithub.com/pterm/pterm) | `v0.12.72` -> `v0.12.73` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | patch | | [github.com/rivo/tview](https://togithub.com/rivo/tview) | `5f07813` -> `b3bd1aa` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | digest | | [gocloud.dev](https://togithub.com/google/go-cloud) | `v0.35.0` -> `v0.36.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | minor | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>aws/aws-sdk-go (github.com/aws/aws-sdk-go)</summary> ### [`v1.49.13`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v14913-2023-12-29) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.49.12...v1.49.13) \=== ##### Service Client Updates - `service/apprunner`: Updates service API and documentation - `service/location`: Updates service API and documentation - `service/quicksight`: Updates service API and documentation - Add LinkEntityArn support for different partitions; Add UnsupportedUserEditionException in UpdateDashboardLinks API; Add support for New Reader Experience Topics ### [`v1.49.12`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v14912-2023-12-28) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.49.11...v1.49.12) \=== ##### Service Client Updates - `service/codestar-connections`: Updates service API - `service/kinesis-video-archived-media`: Updates service API and documentation - `service/sagemaker`: Updates service API and documentation - Amazon SageMaker Studio now supports Docker access from within app container ### [`v1.49.11`](https://togithub.com/aws/aws-sdk-go/blob/HEAD/CHANGELOG.md#Release-v14911-2023-12-27) [Compare Source](https://togithub.com/aws/aws-sdk-go/compare/v1.49.10...v1.49.11) \=== ##### Service Client Updates - `service/elasticmapreduce`: Updates service API and documentation - Add support for customers to modify cluster attribute auto-terminate post cluster launch </details> <details> <summary>cerbos/cloud-api (github.com/cerbos/cloud-api)</summary> ### [`v0.1.13`](https://togithub.com/cerbos/cloud-api/compare/v0.1.12...v0.1.13) [Compare Source](https://togithub.com/cerbos/cloud-api/compare/v0.1.12...v0.1.13) </details> <details> <summary>prometheus/client_golang (github.com/prometheus/client_golang)</summary> ### [`v1.18.0`](https://togithub.com/prometheus/client_golang/releases/tag/v1.18.0) [Compare Source](https://togithub.com/prometheus/client_golang/compare/v1.17.0...v1.18.0) #### What's Changed - \[FEATURE] promlint: Allow creation of custom metric validations. [#​1311](https://togithub.com/prometheus/client_golang/issues/1311) - \[FEATURE] Go programs using client_golang can be built in wasip1 OS. [#​1350](https://togithub.com/prometheus/client_golang/issues/1350) - \[BUGFIX] histograms: Add timer to reset ASAP after bucket limiting has happened. [#​1367](https://togithub.com/prometheus/client_golang/issues/1367) - \[BUGFIX] testutil: Fix comparison of metrics with empty Help strings. [#​1378](https://togithub.com/prometheus/client_golang/issues/1378) - \[ENHANCEMENT] Improved performance of `MetricVec.WithLabelValues(...)`. [#​1360](https://togithub.com/prometheus/client_golang/issues/1360) #### New Contributors - [@​srenatus](https://togithub.com/srenatus) made their first contribution in [prometheus/client_golang#1350 - [@​jadolg](https://togithub.com/jadolg) made their first contribution in [prometheus/client_golang#1342 - [@​manas-rust](https://togithub.com/manas-rust) made their first contribution in [prometheus/client_golang#1383 - [@​bluekeyes](https://togithub.com/bluekeyes) made their first contribution in [prometheus/client_golang#1378 - [@​tsipo](https://togithub.com/tsipo) made their first contribution in [prometheus/client_golang#1387 **Full Changelog**: prometheus/client_golang@v1.17.0...v1.18.0 </details> <details> <summary>pterm/pterm (github.com/pterm/pterm)</summary> ### [`v0.12.73`](https://togithub.com/pterm/pterm/releases/tag/v0.12.73) [Compare Source](https://togithub.com/pterm/pterm/compare/v0.12.72...v0.12.73) <!-- Release notes generated using configuration in .github/release.yml at master --> #### What's Changed ##### Fixes 🔧 - fix(logger): `LogLevelDisabled` does no longer print anything by [@​MarvinJWendt](https://togithub.com/MarvinJWendt) in [pterm/pterm#601 ##### Other Changes - examples: fix typo in demo by [@​jrschumacher](https://togithub.com/jrschumacher) in [pterm/pterm#598 #### New Contributors - [@​jrschumacher](https://togithub.com/jrschumacher) made their first contribution in [pterm/pterm#598 **Full Changelog**: pterm/pterm@v0.12.72...v0.12.73 </details> <details> <summary>google/go-cloud (gocloud.dev)</summary> ### [`v0.36.0`](https://togithub.com/google/go-cloud/releases/tag/v0.36.0) [Compare Source](https://togithub.com/google/go-cloud/compare/v0.35.0...v0.36.0) **blob** - **all**: Allow disabling of `ContentType` auto-detection during writes. **pubsub** - **azuresb**: Added a new auth method to support Service principal/kubelet identity/Workload identity auth methods. **docstore** - **all**: Add in/not-in operators for Query. - **gcpfirestore**: Added a missing resource header when running query. **mysql** - Pass TLS config directly to MySQL's config </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cerbos/cerbos). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
nono
added a commit
to cozy/cozy-stack
that referenced
this pull request
Jan 2, 2024
….0 (#4277) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/client_golang](https://togithub.com/prometheus/client_golang) | `v1.17.0` -> `v1.18.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prometheus/client_golang (github.com/prometheus/client_golang)</summary> ### [`v1.18.0`](https://togithub.com/prometheus/client_golang/releases/tag/v1.18.0) [Compare Source](https://togithub.com/prometheus/client_golang/compare/v1.17.0...v1.18.0) #### What's Changed - \[FEATURE] promlint: Allow creation of custom metric validations. [#​1311](https://togithub.com/prometheus/client_golang/issues/1311) - \[FEATURE] Go programs using client_golang can be built in wasip1 OS. [#​1350](https://togithub.com/prometheus/client_golang/issues/1350) - \[BUGFIX] histograms: Add timer to reset ASAP after bucket limiting has happened. [#​1367](https://togithub.com/prometheus/client_golang/issues/1367) - \[BUGFIX] testutil: Fix comparison of metrics with empty Help strings. [#​1378](https://togithub.com/prometheus/client_golang/issues/1378) - \[ENHANCEMENT] Improved performance of `MetricVec.WithLabelValues(...)`. [#​1360](https://togithub.com/prometheus/client_golang/issues/1360) #### New Contributors - [@​srenatus](https://togithub.com/srenatus) made their first contribution in [prometheus/client_golang#1350 - [@​jadolg](https://togithub.com/jadolg) made their first contribution in [prometheus/client_golang#1342 - [@​manas-rust](https://togithub.com/manas-rust) made their first contribution in [prometheus/client_golang#1383 - [@​bluekeyes](https://togithub.com/bluekeyes) made their first contribution in [prometheus/client_golang#1378 - [@​tsipo](https://togithub.com/tsipo) made their first contribution in [prometheus/client_golang#1387 **Full Changelog**: prometheus/client_golang@v1.17.0...v1.18.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on Monday" in timezone Europe/Paris, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cozy/cozy-stack). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
jooola
pushed a commit
to hetznercloud/hcloud-go
that referenced
this pull request
Jan 2, 2024
) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/client_golang](https://togithub.com/prometheus/client_golang) | `v1.17.0` -> `v1.18.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prometheus/client_golang (github.com/prometheus/client_golang)</summary> ### [`v1.18.0`](https://togithub.com/prometheus/client_golang/releases/tag/v1.18.0): v0.18.0 [Compare Source](https://togithub.com/prometheus/client_golang/compare/v1.17.0...v1.18.0) #### What's Changed - \[FEATURE] promlint: Allow creation of custom metric validations. [#​1311](https://togithub.com/prometheus/client_golang/issues/1311) - \[FEATURE] Go programs using client_golang can be built in wasip1 OS. [#​1350](https://togithub.com/prometheus/client_golang/issues/1350) - \[BUGFIX] histograms: Add timer to reset ASAP after bucket limiting has happened. [#​1367](https://togithub.com/prometheus/client_golang/issues/1367) - \[BUGFIX] testutil: Fix comparison of metrics with empty Help strings. [#​1378](https://togithub.com/prometheus/client_golang/issues/1378) - \[ENHANCEMENT] Improved performance of `MetricVec.WithLabelValues(...)`. [#​1360](https://togithub.com/prometheus/client_golang/issues/1360) #### New Contributors - [@​srenatus](https://togithub.com/srenatus) made their first contribution in [prometheus/client_golang#1350 - [@​jadolg](https://togithub.com/jadolg) made their first contribution in [prometheus/client_golang#1342 - [@​manas-rust](https://togithub.com/manas-rust) made their first contribution in [prometheus/client_golang#1383 - [@​bluekeyes](https://togithub.com/bluekeyes) made their first contribution in [prometheus/client_golang#1378 - [@​tsipo](https://togithub.com/tsipo) made their first contribution in [prometheus/client_golang#1387 **Full Changelog**: prometheus/client_golang@v1.17.0...v1.18.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/hetznercloud/hcloud-go). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
jooola
pushed a commit
to hetznercloud/hcloud-cloud-controller-manager
that referenced
this pull request
Jan 2, 2024
) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/client_golang](https://togithub.com/prometheus/client_golang) | `v1.17.0` -> `v1.18.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prometheus/client_golang (github.com/prometheus/client_golang)</summary> ### [`v1.18.0`](https://togithub.com/prometheus/client_golang/releases/tag/v1.18.0): v0.18.0 [Compare Source](https://togithub.com/prometheus/client_golang/compare/v1.17.0...v1.18.0) #### What's Changed - \[FEATURE] promlint: Allow creation of custom metric validations. [#​1311](https://togithub.com/prometheus/client_golang/issues/1311) - \[FEATURE] Go programs using client_golang can be built in wasip1 OS. [#​1350](https://togithub.com/prometheus/client_golang/issues/1350) - \[BUGFIX] histograms: Add timer to reset ASAP after bucket limiting has happened. [#​1367](https://togithub.com/prometheus/client_golang/issues/1367) - \[BUGFIX] testutil: Fix comparison of metrics with empty Help strings. [#​1378](https://togithub.com/prometheus/client_golang/issues/1378) - \[ENHANCEMENT] Improved performance of `MetricVec.WithLabelValues(...)`. [#​1360](https://togithub.com/prometheus/client_golang/issues/1360) #### New Contributors - [@​srenatus](https://togithub.com/srenatus) made their first contribution in [prometheus/client_golang#1350 - [@​jadolg](https://togithub.com/jadolg) made their first contribution in [prometheus/client_golang#1342 - [@​manas-rust](https://togithub.com/manas-rust) made their first contribution in [prometheus/client_golang#1383 - [@​bluekeyes](https://togithub.com/bluekeyes) made their first contribution in [prometheus/client_golang#1378 - [@​tsipo](https://togithub.com/tsipo) made their first contribution in [prometheus/client_golang#1387 **Full Changelog**: prometheus/client_golang@v1.17.0...v1.18.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/hetznercloud/hcloud-cloud-controller-manager). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
jooola
pushed a commit
to hetznercloud/csi-driver
that referenced
this pull request
Jan 2, 2024
) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/client_golang](https://togithub.com/prometheus/client_golang) | `v1.17.0` -> `v1.18.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prometheus/client_golang (github.com/prometheus/client_golang)</summary> ### [`v1.18.0`](https://togithub.com/prometheus/client_golang/releases/tag/v1.18.0): v0.18.0 [Compare Source](https://togithub.com/prometheus/client_golang/compare/v1.17.0...v1.18.0) #### What's Changed - \[FEATURE] promlint: Allow creation of custom metric validations. [#​1311](https://togithub.com/prometheus/client_golang/issues/1311) - \[FEATURE] Go programs using client_golang can be built in wasip1 OS. [#​1350](https://togithub.com/prometheus/client_golang/issues/1350) - \[BUGFIX] histograms: Add timer to reset ASAP after bucket limiting has happened. [#​1367](https://togithub.com/prometheus/client_golang/issues/1367) - \[BUGFIX] testutil: Fix comparison of metrics with empty Help strings. [#​1378](https://togithub.com/prometheus/client_golang/issues/1378) - \[ENHANCEMENT] Improved performance of `MetricVec.WithLabelValues(...)`. [#​1360](https://togithub.com/prometheus/client_golang/issues/1360) #### New Contributors - [@​srenatus](https://togithub.com/srenatus) made their first contribution in [prometheus/client_golang#1350 - [@​jadolg](https://togithub.com/jadolg) made their first contribution in [prometheus/client_golang#1342 - [@​manas-rust](https://togithub.com/manas-rust) made their first contribution in [prometheus/client_golang#1383 - [@​bluekeyes](https://togithub.com/bluekeyes) made their first contribution in [prometheus/client_golang#1378 - [@​tsipo](https://togithub.com/tsipo) made their first contribution in [prometheus/client_golang#1387 **Full Changelog**: prometheus/client_golang@v1.17.0...v1.18.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/hetznercloud/csi-driver). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
bogdandrutu
pushed a commit
to open-telemetry/opentelemetry-collector
that referenced
this pull request
Jan 2, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/client_golang](https://togithub.com/prometheus/client_golang) | `v1.17.0` -> `v1.18.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prometheus/client_golang (github.com/prometheus/client_golang)</summary> ### [`v1.18.0`](https://togithub.com/prometheus/client_golang/releases/tag/v1.18.0) [Compare Source](https://togithub.com/prometheus/client_golang/compare/v1.17.0...v1.18.0) #### What's Changed - \[FEATURE] promlint: Allow creation of custom metric validations. [#​1311](https://togithub.com/prometheus/client_golang/issues/1311) - \[FEATURE] Go programs using client_golang can be built in wasip1 OS. [#​1350](https://togithub.com/prometheus/client_golang/issues/1350) - \[BUGFIX] histograms: Add timer to reset ASAP after bucket limiting has happened. [#​1367](https://togithub.com/prometheus/client_golang/issues/1367) - \[BUGFIX] testutil: Fix comparison of metrics with empty Help strings. [#​1378](https://togithub.com/prometheus/client_golang/issues/1378) - \[ENHANCEMENT] Improved performance of `MetricVec.WithLabelValues(...)`. [#​1360](https://togithub.com/prometheus/client_golang/issues/1360) #### New Contributors - [@​srenatus](https://togithub.com/srenatus) made their first contribution in [prometheus/client_golang#1350 - [@​jadolg](https://togithub.com/jadolg) made their first contribution in [prometheus/client_golang#1342 - [@​manas-rust](https://togithub.com/manas-rust) made their first contribution in [prometheus/client_golang#1383 - [@​bluekeyes](https://togithub.com/bluekeyes) made their first contribution in [prometheus/client_golang#1378 - [@​tsipo](https://togithub.com/tsipo) made their first contribution in [prometheus/client_golang#1387 **Full Changelog**: prometheus/client_golang@v1.17.0...v1.18.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
bogdandrutu
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Jan 2, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/client_golang](https://togithub.com/prometheus/client_golang) | `v1.17.0` -> `v1.18.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prometheus/client_golang (github.com/prometheus/client_golang)</summary> ### [`v1.18.0`](https://togithub.com/prometheus/client_golang/releases/tag/v1.18.0) [Compare Source](https://togithub.com/prometheus/client_golang/compare/v1.17.0...v1.18.0) #### What's Changed - \[FEATURE] promlint: Allow creation of custom metric validations. [#​1311](https://togithub.com/prometheus/client_golang/issues/1311) - \[FEATURE] Go programs using client_golang can be built in wasip1 OS. [#​1350](https://togithub.com/prometheus/client_golang/issues/1350) - \[BUGFIX] histograms: Add timer to reset ASAP after bucket limiting has happened. [#​1367](https://togithub.com/prometheus/client_golang/issues/1367) - \[BUGFIX] testutil: Fix comparison of metrics with empty Help strings. [#​1378](https://togithub.com/prometheus/client_golang/issues/1378) - \[ENHANCEMENT] Improved performance of `MetricVec.WithLabelValues(...)`. [#​1360](https://togithub.com/prometheus/client_golang/issues/1360) #### New Contributors - [@​srenatus](https://togithub.com/srenatus) made their first contribution in [prometheus/client_golang#1350 - [@​jadolg](https://togithub.com/jadolg) made their first contribution in [prometheus/client_golang#1342 - [@​manas-rust](https://togithub.com/manas-rust) made their first contribution in [prometheus/client_golang#1383 - [@​bluekeyes](https://togithub.com/bluekeyes) made their first contribution in [prometheus/client_golang#1378 - [@​tsipo](https://togithub.com/tsipo) made their first contribution in [prometheus/client_golang#1387 **Full Changelog**: prometheus/client_golang@v1.17.0...v1.18.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
kakkoyun
added a commit
to parca-dev/parca-agent
that referenced
this pull request
Jan 8, 2024
…18.0 (#2401) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/client_golang](https://togithub.com/prometheus/client_golang) | `v1.17.0` -> `v1.18.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>prometheus/client_golang (github.com/prometheus/client_golang)</summary> ### [`v1.18.0`](https://togithub.com/prometheus/client_golang/releases/tag/v1.18.0) [Compare Source](https://togithub.com/prometheus/client_golang/compare/v1.17.0...v1.18.0) #### What's Changed - \[FEATURE] promlint: Allow creation of custom metric validations. [#​1311](https://togithub.com/prometheus/client_golang/issues/1311) - \[FEATURE] Go programs using client_golang can be built in wasip1 OS. [#​1350](https://togithub.com/prometheus/client_golang/issues/1350) - \[BUGFIX] histograms: Add timer to reset ASAP after bucket limiting has happened. [#​1367](https://togithub.com/prometheus/client_golang/issues/1367) - \[BUGFIX] testutil: Fix comparison of metrics with empty Help strings. [#​1378](https://togithub.com/prometheus/client_golang/issues/1378) - \[ENHANCEMENT] Improved performance of `MetricVec.WithLabelValues(...)`. [#​1360](https://togithub.com/prometheus/client_golang/issues/1360) #### New Contributors - [@​srenatus](https://togithub.com/srenatus) made their first contribution in [prometheus/client_golang#1350 - [@​jadolg](https://togithub.com/jadolg) made their first contribution in [prometheus/client_golang#1342 - [@​manas-rust](https://togithub.com/manas-rust) made their first contribution in [prometheus/client_golang#1383 - [@​bluekeyes](https://togithub.com/bluekeyes) made their first contribution in [prometheus/client_golang#1378 - [@​tsipo](https://togithub.com/tsipo) made their first contribution in [prometheus/client_golang#1387 **Full Changelog**: prometheus/client_golang@v1.17.0...v1.18.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/parca-dev/parca-agent). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jan 10, 2024
](https://renovatebot.com){kind=link}
…lemetry#30250) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/client_golang](https://togithub.com/prometheus/client_golang) | `v1.17.0` -> `v1.18.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prometheus/client_golang (github.com/prometheus/client_golang)</summary> ### [`v1.18.0`](https://togithub.com/prometheus/client_golang/releases/tag/v1.18.0) [Compare Source](https://togithub.com/prometheus/client_golang/compare/v1.17.0...v1.18.0) #### What's Changed - \[FEATURE] promlint: Allow creation of custom metric validations. [#&open-telemetry#8203;1311](https://togithub.com/prometheus/client_golang/issues/1311) - \[FEATURE] Go programs using client_golang can be built in wasip1 OS. [#&open-telemetry#8203;1350](https://togithub.com/prometheus/client_golang/issues/1350) - \[BUGFIX] histograms: Add timer to reset ASAP after bucket limiting has happened. [#&open-telemetry#8203;1367](https://togithub.com/prometheus/client_golang/issues/1367) - \[BUGFIX] testutil: Fix comparison of metrics with empty Help strings. [#&open-telemetry#8203;1378](https://togithub.com/prometheus/client_golang/issues/1378) - \[ENHANCEMENT] Improved performance of `MetricVec.WithLabelValues(...)`. [#&open-telemetry#8203;1360](https://togithub.com/prometheus/client_golang/issues/1360) #### New Contributors - [@&open-telemetry#8203;srenatus](https://togithub.com/srenatus) made their first contribution in [prometheus/client_golang#1350 - [@&open-telemetry#8203;jadolg](https://togithub.com/jadolg) made their first contribution in [prometheus/client_golang#1342 - [@&open-telemetry#8203;manas-rust](https://togithub.com/manas-rust) made their first contribution in [prometheus/client_golang#1383 - [@&open-telemetry#8203;bluekeyes](https://togithub.com/bluekeyes) made their first contribution in [prometheus/client_golang#1378 - [@&open-telemetry#8203;tsipo](https://togithub.com/tsipo) made their first contribution in [prometheus/client_golang#1387 **Full Changelog**: prometheus/client_golang@v1.17.0...v1.18.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an inconsistency in the text protocol between encoding and decoding, it was not possible to use the
testutil.CollectAndComparefunction to test metrics with empty help values. To fix this, normalize empty help values from the expected/want side of the test so that they compare correctly with empty values on the actual/got side of the test.Fixes #1308.