Add LintDuplicateMetric to promlint #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hrishikesh Barman <hrishikeshbman@gmail.com>
ArthurSens
approved these changes
Mar 24, 2024
Comment on lines
+30
to
+31
| problems = append(problems, fmt.Errorf("metric not unique")) | ||
| break |
There was a problem hiding this comment.
If we break here we'll only return the first problem. Since we're returning an array of errors I wonder if we don't want to return all duplicated metrics instead of only the first one.
There was a problem hiding this comment.
Nevermind, I've just realized we're braking only the inner for loop
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is from prometheus/prometheus#5312; the code moved to this repo since that PR was opened.
@geekodour is the original author.