Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace AUTHORS.md by an updated MAINTAINERS.md #279

Merged
merged 1 commit into from Feb 17, 2017
Merged

Conversation

beorn7
Copy link
Member

@beorn7 beorn7 commented Feb 16, 2017

Also, note the unmaintained state of the API client in the README.md

@grobie

README.md Outdated
@@ -30,7 +30,9 @@ The
[`api/prometheus` directory](https://github.com/prometheus/client_golang/tree/master/api/prometheus)
contains the client for the
[Prometheus HTTP API](http://prometheus.io/docs/querying/api/). It allows you
to write Go applications that query time series data from a Prometheus server.
to write Go applications that query time series data from a Prometheus
server. It is in an early stage and further development is currently on hold
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be wary of including such a statement in a readme, it may be misconstrued to mean the whole client is unmaintained.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is your suggestion instead?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd mention it's alpha.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But how can we express that there will be nobody reviewing PRs?

And how does the "it's alpha" not reflect on the whole client with the same argument you used above? (I don't think this misunderstanding is likely. I'm just trying to understand your line of reasoning.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That we're not developing isn't the same as not reviewing PRs. I presume at least one of us has review capacity if someone started fleshing it out.

And how does the "it's alpha" not reflect on the whole client with the same argument you used above?

It does, but being alpha is much better than a part of the project being unmaintained and thus dead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll remember to assign PRs to you, if they come in... ;)

Also, note the unmaintained state of the API client in the README.md
@beorn7 beorn7 merged commit 6ab3432 into master Feb 17, 2017
@beorn7 beorn7 deleted the beorn7/meta branch February 17, 2017 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants