Make Counter faster for simple Inc or Add with an integer #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically @beorn7 pointed out that the previous implementation had some shortcomings around large numbers. I've changed the code to match the suggestion in review, as well as added a few test cases.
…golang into beorn7/counter
Original discussion see #362 . Assuming that the most frequently used method of a `Gauge` is `Set` and the most frequently used method of a `Conuter` is `Inc`, this separates the implementation of both metric types. `Inc` and integral `Add` of a counter is now handled in a separate `uint64`. This would create a race in `Set`, but luckily, there is no `Set` anymore in a counter. All attempts to solve above race (to use the same idea for a `Gauge`) slow down `Set`, So we just stick with the old implementation (formerly `value`) for `Gauge`.
Closed
grobie
approved these changes
Jan 19, 2018
|
The existing BEFORE: AFTER: |
|
@smcquay had more sophisticated benchmarks, I believe. If they could be contributed easily, I would appreciate it. |
|
I will dig them up and submit them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@grobie
@smcquay This is implementing what I had suggested on top of your change.