Add a package promauto that provides auto-registering metrics #385
Conversation
|
Oh nice! |
| // The only way is panicking. While panicking on invalid input provided by the | ||
| // programmer is certainly fine, things are a bit more subtle in this case: You | ||
| // might just add another package to the program, and that package (in its init | ||
| // function) happens to register a metric with the same name as your code. Now, |
There was a problem hiding this comment.
I'd change this to cover it happening at runtime due to loading some new code somehow (plugin?). Crashing out at startup isn't that bad, as it'll be pretty obvious from unittests. When you're already up and running however it's an outage.
There was a problem hiding this comment.
I'll add something along the lines "even worse, during runtime". But I want to keep the panic-at-startup scenario in there as well as many proficient Go devs feel strongly about it, too.
Which I had considered earlier, but rejected it, as idiomatic Go tends to reduce the number of methods in an interface. You would essentially pollute the interface for everybody who doesn't want to deal with global state anyway. That's why I'm so happy with the package solution here. Whoever wants to go down the "easy" path, just uses this package. Slightly different name when calling the constructors, that's very little friction, while the purists will never even notice that the package exists. |
Finally, I found an easy solution to provide the "evil" auto-registration without getting death threats from the wardens of Go purity. The reasoning can be found in the package's doc comment.
|
Improved the package doc comment to include comments above. |
|
👍 |
Finally, I found an easy solution to provide the "evil"
auto-registration without getting death threats from the wardens of Go
purity. The reasoning can be found in the package's doc comment.
@brian-brazil I think you will like this.
@grobie next time you give an instrumentation introduction, you can use this package and ignore the registry with its Registerer and Gatherer interfaces altogether.