-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a simple buildInfoCollector #595
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yeah, the example needs to get a build tag, too. |
6bfe478
to
a2f08db
Compare
@povilasv What do you think? |
brian-brazil
reviewed
Jun 6, 2019
f3a4137
to
575e78f
Compare
This works, but I'll change the file structure to not repeat so much doc comment. |
Signed-off-by: beorn7 <beorn@grafana.com>
575e78f
to
8576729
Compare
OK, all done. |
👍 |
You can try it out:
|
Merging now. @povilasv your input is still welcome. |
Nice work :) Read thru the code and tested examples, everything works as documented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is now kind of meant as complementary to https://github.com/povilasv/prommod , see doc comment. https://github.com/povilasv/prommod is concerned with the dependencies, while this simple collector is only doing the main module. It is, if you want, the poor person's version of prometheus/common/version. If you build your binaries in the "right" (modules) way, you get the version info for free without setting any build variables.
Since many users might not build their binaries in that "right" way yet, and some might not want to disclose their package path or version, this collector is not registered with the default registry.