Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /labels API to client #604

Merged
merged 1 commit into from
Jun 14, 2019
Merged

Conversation

jacksontj
Copy link
Contributor

@beorn7
Copy link
Member

beorn7 commented Jun 14, 2019

Note: I plan to cut v1 today. Would be cool to get this in if it is ready for it.

@krasi-georgiev krasi-georgiev merged commit f213ad9 into prometheus:master Jun 14, 2019
@krasi-georgiev
Copy link
Contributor

Thanks!

@jacksontj
Copy link
Contributor Author

@beorn7 as long as we aren't moving this client to GA yet. IMO prometheus/prometheus#5661 should get done first -- so we don't have to do another interface break.

@jacksontj jacksontj deleted the labels branch June 14, 2019 15:15
@beorn7
Copy link
Member

beorn7 commented Jun 14, 2019

@jacksontj What is GA?
I would like to do v1 of client_golang very soon and not wait for Prometheus v2.11.
The API client will be explicitly excluded from semver guarantees.

@jacksontj
Copy link
Contributor Author

@beorn7 I was referring to making this API client "GA" (meaning it follows the semver stuff) -- I wasn't sure what all was included in a v1 release. So if this API client remains as "experimental" (so we can break the API as needed), I'm fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants