Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Delete method to Pusher #613

Merged
merged 2 commits into from
Jun 28, 2019
Merged

Add Delete method to Pusher #613

merged 2 commits into from
Jun 28, 2019

Conversation

beorn7
Copy link
Member

@beorn7 beorn7 commented Jun 28, 2019

Fixes #611.

@nnoto what do you think?

This allows

push.New("http://localhost:9091", "some_job").Grouping("foo", "bar").Delete(),

Fixes #611.

Signed-off-by: beorn7 <beorn@grafana.com>
Signed-off-by: beorn7 <beorn@grafana.com>
@nnoto
Copy link

nnoto commented Jun 28, 2019

Looks good to me, much appreciated!

@beorn7
Copy link
Member Author

beorn7 commented Jun 28, 2019

OK, I'll merge. You can use it by building from head. I'll see what else is in the pipeline to decide when to cut a release.

@beorn7 beorn7 merged commit a6c6979 into master Jun 28, 2019
@beorn7 beorn7 deleted the beorn7/push branch June 28, 2019 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for DELETE calls to PushGateway
2 participants