Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements to the push code #654

Merged
merged 2 commits into from
Oct 15, 2019
Merged

Minor improvements to the push code #654

merged 2 commits into from
Oct 15, 2019

Conversation

beorn7
Copy link
Member

@beorn7 beorn7 commented Oct 14, 2019

  • Match fake-Pushgateway's behavior to v0.10+ in the test.
  • Use constants for status code, not number literals.

@beorn7
Update push test to use status code 200
f24de70 
Signed-off-by: beorn7 <beorn@grafana.com>
@beorn7
Use HTTP status code constants rather than numerical literals
bd362a9 
Signed-off-by: beorn7 <beorn@grafana.com>
@brian-brazil
Copy link
Contributor

👍

@beorn7
Copy link
Member Author

beorn7 commented Oct 15, 2019

Thanks everyone.

@beorn7 beorn7 merged commit e0e84de into master Oct 15, 2019
@beorn7 beorn7 deleted the beorn7/push branch October 15, 2019 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codesome codesome codesome approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@beorn7 @brian-brazil @codesome