Added code to correctly handle HEAD request #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Doug Hoard <doug.hoard@gmail.com>
|
cc @fstab @tomwilkie |
fstab
reviewed
Sep 10, 2021
There was a problem hiding this comment.
Thanks a lot for the PR. I tried to reproduce the bug, but I could not find a single Java version where the HEAD request doesn't work. Even with Azul's Java 6 it works. Moreover, the current implementation handles headers correctly, so if I run
curl -i --head -H 'Accept: application/openmetrics-text; version=1.0.0; charset=utf-8' http://localhost:9000/metrics
I get the correct Content-type and Content-length.
Are you aware of any Java version where HEAD requests don't work? I would only fix it if it is a real problem.
simpleclient_httpserver/src/main/java/io/prometheus/client/exporter/HTTPServer.java
Outdated
Show resolved
Hide resolved
simpleclient_httpserver/src/main/java/io/prometheus/client/exporter/HTTPServer.java
Outdated
Show resolved
Hide resolved
|
I just saw that #685 is linked here, I commented there as well. |
Signed-off-by: Doug Hoard <doug.hoard@gmail.com>
|
I updated the PR. The issue is around the generation of the warning message. I have updated #685 with specifics. |
fstab
approved these changes
Sep 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Doug Hoard doug.hoard@gmail.com