Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor HTTPMetricsHandler to have public constructors #722

Merged
merged 2 commits into from
Nov 29, 2021

Conversation

dhoard
Copy link
Collaborator

@dhoard dhoard commented Nov 27, 2021

Refactored HTTPMetricsHandler to an external class to resolve #720

Signed-off-by: Doug Hoard doug.hoard@gmail.com

@dhoard
Copy link
Collaborator Author

dhoard commented Nov 27, 2021

cc @fstab

Signed-off-by: Doug Hoard <doug.hoard@gmail.com>
@dhoard dhoard changed the title Refactor HTTPMetricsHandler to an external class Refactor HTTPMetricsHandler to have public constructors Nov 28, 2021
@fstab fstab merged commit 48c18e5 into prometheus:master Nov 29, 2021
@fstab
Copy link
Member

fstab commented Nov 29, 2021

Thanks a lot @dhoard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make HTTPMetricHandler constructor public so people can use it in their own servers.
2 participants