Remove scrape() from getPrometheusName() default implementation #875
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Collector
(andMultiCollector
) interface defines a methodgetPrometheusName()
(orgetPrometheusNames()
) to get the list of metric names produced by the collector.This method is optional. It is used during registration to check for duplicate metrics, and it is used during scrape if a name filter is present to check if this collector can be skipped because the name(s) are excluded.
The default implementation was to call
collect()
to learn the Prometheus names. However, this leads to twocollect()
calls when scraping: The first to check the name filter, the second for the actual scrape.With this PR we change this to returning
null
(or empty list) indicating that the names are unknown.This does not affect the metrics in
prometheus-metrics-core
, because all metrics inprometheus-metrics-core
override this.