Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.remove and .clear not working with multiprocessing mode #916

Closed
MarcoRizk opened this issue May 31, 2023 · 5 comments · Fixed by #1003
Closed

.remove and .clear not working with multiprocessing mode #916

MarcoRizk opened this issue May 31, 2023 · 5 comments · Fixed by #1003

Comments

@MarcoRizk
Copy link

Trying to remove a given set of labels for a metric doesn't work.
The label value is still readable by the collector after it's presumed removal ?
any suggestions ?

@hatamiarash7
Copy link

I have this problem too

@csmarchbanks
Copy link
Member

Yep, this is definitely an issue. At a minimum we should document that they do not work in the multiprocessing section of the readme, but ideally we could figure out a way to support remove/clear in multiprocess.

@yctomwang
Copy link
Contributor

@csmarchbanks Hi Chris, I also run into this issue. After looking around the code base I think its because of the disconnection between the remove of Normal Metrics and the multiprocess ones. I thinking add a warning message aswell as in the documentation/README would benefit a lot of others. Happy to put together a PR for this. Thanks again for maintiaining such an awesome libaray!

@csmarchbanks
Copy link
Member

👍 That would be great, thank you!

@yctomwang
Copy link
Contributor

@csmarchbanks Hi Chris, I got the PR in, would be nice if you could review it when you have free time, thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants