Raise an exception when setting gauge to nil

prometheus · Feb 20, 2017 · 446c3d9 · 446c3d9
1 parent 5033c15
commit 446c3d9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/lib/prometheus/client/gauge.rb b/lib/prometheus/client/gauge.rb
@@ -13,6 +13,10 @@ def type
 
       # Sets the value for the given label set
       def set(labels, value)
+        unless value.is_a?(Numeric)
+          raise ArgumentError, 'value must be a number'
+        end
+
         @values[label_set_for(labels)] = value
       end
     end

diff --git a/spec/prometheus/client/gauge_spec.rb b/spec/prometheus/client/gauge_spec.rb
@@ -24,5 +24,13 @@
         end.to change { gauge.get(test: 'value') }.from(nil).to(42)
       end.to_not change { gauge.get }
     end
+
+    context 'given an invalid value' do
+      it 'raises an ArgumentError' do
+        expect do
+          gauge.set({}, nil)
+        end.to raise_exception(ArgumentError)
+      end
+    end
   end
 end