Add missing _bucket suffix to histogram counters

prometheus · May 24, 2017 · a75670f · a75670f
1 parent 8f04701
commit a75670f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/lib/prometheus/client/formats/text.rb b/lib/prometheus/client/formats/text.rb
@@ -62,10 +62,11 @@ def summary(name, set, value)
           end
 
           def histogram(name, set, value)
+            bucket = "#{name}_bucket"
             value.each do |q, v|
-              yield metric(name, labels(set.merge(le: q)), v)
+              yield metric(bucket, labels(set.merge(le: q)), v)
             end
-            yield metric(name, labels(set.merge(le: '+Inf')), value.total)
+            yield metric(bucket, labels(set.merge(le: '+Inf')), value.total)
 
             l = labels(set)
             yield metric("#{name}_sum", l, value.sum)

diff --git a/spec/prometheus/client/formats/text_spec.rb b/spec/prometheus/client/formats/text_spec.rb
@@ -91,10 +91,10 @@
 qux_count{for="sake",code="1"} 93
 # TYPE xuq histogram
 # HELP xuq xuq description
-xuq{code="ah",le="10"} 1.0
-xuq{code="ah",le="20"} 2.0
-xuq{code="ah",le="30"} 2.0
-xuq{code="ah",le="+Inf"} 2.0
+xuq_bucket{code="ah",le="10"} 1.0
+xuq_bucket{code="ah",le="20"} 2.0
+xuq_bucket{code="ah",le="30"} 2.0
+xuq_bucket{code="ah",le="+Inf"} 2.0
 xuq_sum{code="ah"} 15.2
 xuq_count{code="ah"} 2.0
       TEXT